Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix docs URL in badge #2422

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: fix docs URL in badge #2422

merged 1 commit into from
Jul 2, 2024

Conversation

sk1p
Copy link
Contributor

@sk1p sk1p commented Jul 1, 2024

rtd.io is on longer (?) operational, according to the project page the correct domain is either rtfd.io or the full readthedocs.io. Also switch to https.

Purpose of PR?:

Fix broken badge.

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@ReimarBauer
Copy link
Member

@sk1p Thanks, that you help us. \o/
Please can you send this us to stable, we do bug fixes there. That gets then merged into develop.

@ReimarBauer ReimarBauer linked an issue Jul 1, 2024 that may be closed by this pull request
fix rtfd url for a badge #2423
Closed
@sk1p sk1p changed the base branch from develop to stable July 1, 2024 20:56
@sk1p
Copy link
Contributor Author

sk1p commented Jul 1, 2024

@sk1p Thanks, that you help us. \o/
Please can you send this us to stable, we do bug fixes there. That gets then merged into develop.

Sure, I've changed the base branch of the pr to stable, hope that worked out.

@ReimarBauer
Copy link
Member

@sk1p Thanks, that you help us. \o/
Please can you send this us to stable, we do bug fixes there. That gets then merged into develop.

Sure, I've changed the base branch of the pr to stable, hope that worked out.

Currently develop has no further changes than the release. squashing should be fine.

@ReimarBauer
Copy link
Member

ah, that needs a rebase to stable, because the skyfield-data fix is only there.

@sk1p
Fix docs URL
e370297 
`rtd.io` is on longer operational, according to [the project page](https://readthedocs.org/projects/mss/) the correct domain is either `rtfd.io` or the full `readthedocs.io`. Also switch to https.
@sk1p
Copy link
Contributor Author

sk1p commented Jul 2, 2024

ah, that needs a rebase to stable, because the skyfield-data fix is only there.

Rebased.

ReimarBauer
ReimarBauer approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ReimarBauer ReimarBauer merged commit 92ea726 into Open-MSS:stable Jul 2, 2024
10 of 11 checks passed
@sk1p sk1p deleted the patch-1 branch July 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix rtfd url for a badge
2 participants
@sk1p @ReimarBauer